New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SetBurstModeOffAsync return statement #2132

Merged

kblok merged 1 commit into hardkoded:master from jnyrup:SetBurstModeOffAsync

Apr 9, 2023

Contributor

jnyrup commented Apr 8, 2023

#705 (comment) suggested to return ResetBackgroundColorAndViewportAsync directly to save an await when _screenshotBurstModeOptions is not set.

f18c3f1 missed the return, so ResetBackgroundColorAndViewportAsync may not be complete when await SetBurstModeOffAsync completes.


          await SetBurstModeOffAsync

a8e4b9c

kblok changed the title ~~await SetBurstModeOffAsync~~ Improve SetBurstModeOffAsync return statement

kblok approved these changes

View reviewed changes

kblok merged commit c2f90eb into hardkoded:master

jnyrup deleted the SetBurstModeOffAsync branch

April 9, 2023 20:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet