Initialize logging earlier #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an event handler is attached as part of the constructor and invoked before `_logger` has been populated we might throw an NRE.
kblok
approved these changes
Jun 1, 2023
leonardo-fernandes
pushed a commit
to leonardo-fernandes/puppeteer-sharp
that referenced
this pull request
Jun 2, 2023
When an event handler is attached as part of the constructor and invoked before `_logger` has been populated we might throw an NRE.
This was referenced Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an event handler is attached as part of the constructor and invoked before
_loggerhas been populated we might throw an NRE.Found by @leonardo-fernandes