Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade chrome to 1108766 #2259

Merged
merged 7 commits into from
Jul 26, 2023
Merged

Upgrade chrome to 1108766 #2259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5a25bcf
Upgrade chrome to 1115057
kblok Jul 21, 2023
a5e78c7
Use 1108766 instead
kblok Jul 21, 2023
382dfe5
Fix some tests
kblok Jul 21, 2023
b7d33f5
Prevent flaky test
kblok Jul 21, 2023
5e14563
Fix FrameGotoTests
kblok Jul 21, 2023
6a43da1
Fix new assertion
kblok Jul 24, 2023
15b1e95
unflake
kblok Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/PuppeteerSharp.Tests/CoverageTests/CSSCoverageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ public async Task ShouldWorkWithMediaQueries()
{
new CoverageEntryRange
{
Start = 17,
End = 38
Start = 8,
End = 40
}
}, coverage[0].Ranges);
}
Expand All @@ -111,8 +111,8 @@ public async Task ShouldWorkWithComplicatedUsecases()
""End"": 297
},
{
""Start"": 327,
""End"": 433
""Start"": 306,
""End"": 435
}
],
""Text"": ""\n @charset \""utf - 8\"";\n@namespace svg url(http://www.w3.org/2000/svg);\n@font-face {\n font-family: \""Example Font\"";\n src: url(\""./Dosis-Regular.ttf\"");\n}\n\n#fluffy {\n border: 1px solid black;\n z-index: 1;\n /* -webkit-disabled-property: rgb(1, 2, 3) */\n -lol-cats: \""dogs\"" /* non-existing property */\n}\n\n@media (min-width: 1px) {\n span {\n -webkit-border-radius: 10px;\n font-family: \""Example Font\"";\n animation: 1s identifier;\n }\n}\n""
Expand Down
2 changes: 2 additions & 0 deletions lib/PuppeteerSharp.Tests/CoverageTests/JSCoverageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ public async Task ShouldReportSourceUrls()
{
await Page.Coverage.StartJSCoverageAsync();
await Page.GoToAsync(TestConstants.ServerUrl + "/jscoverage/sourceurl.html");
// Prevent flaky tests.
await Task.Delay(1000);
var coverage = await Page.Coverage.StopJSCoverageAsync();
Assert.Single(coverage);
Assert.Equal("nicename.js", coverage[0].Url);
Expand Down
13 changes: 11 additions & 2 deletions lib/PuppeteerSharp.Tests/NavigationTests/FrameGoToTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
using System.Collections.Generic;
using System.Linq;
using System.Net;
using System.Threading.Tasks;
Expand Down Expand Up @@ -41,7 +40,17 @@ public async Task ShouldRejectWhenFrameDetaches()
await waitForRequestTask;
await Page.QuerySelectorAsync("iframe").EvaluateFunctionAsync("frame => frame.remove()");
var exception = await Assert.ThrowsAsync<NavigationException>(async () => await navigationTask);
Assert.Equal("Navigating frame was detached", exception.Message);
Assert.Contains(
new[]
{
exception.Message
},
message => new[]
{
"Navigating frame was detached",
"Error: NS_BINDING_ABORTED",
"net::ERR_ABORTED"
}.Any(error => message.Contains(error)));
}

[PuppeteerTest("navigation.spec.ts", "Frame.goto", "should return matching responses")]
Expand Down
3 changes: 3 additions & 0 deletions lib/PuppeteerSharp.Tests/PageTests/ExposeFunctionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,9 @@ public async Task ShouldKeepTheCallbackClean()
await Page.ExposeFunctionAsync("compute", (int a, int b) => a * b);
await Page.EvaluateFunctionAsync<int>("async () => await compute(9, 4)");

// Giving a tiny wait to let the connection clear the callback list.
await Task.Delay(300);

// For CI/CD debugging purposes
var session = (CDPSession)Page.Client;
var message = "Expected an empty callback list. Found: \n";
Expand Down
2 changes: 1 addition & 1 deletion lib/PuppeteerSharp/BrowserFetcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public class BrowserFetcher : IBrowserFetcher
/// <summary>
/// Default chromium revision.
/// </summary>
public const string DefaultChromiumRevision = "1069273";
public const string DefaultChromiumRevision = "1108766";

private const string PublishSingleFileLocalApplicationDataFolderName = "PuppeteerSharp";

Expand Down
8 changes: 4 additions & 4 deletions lib/PuppeteerSharp/PuppeteerSharp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
<Description>Headless Browser .NET API</Description>
<PackageId>PuppeteerSharp</PackageId>
<PackageReleaseNotes></PackageReleaseNotes>
<PackageVersion>10.1.2</PackageVersion>
<ReleaseVersion>10.1.2</ReleaseVersion>
<AssemblyVersion>10.1.2.0</AssemblyVersion>
<FileVersion>10.1.2.0</FileVersion>
<PackageVersion>10.1.3</PackageVersion>
<ReleaseVersion>10.1.3</ReleaseVersion>
<AssemblyVersion>10.1.3.0</AssemblyVersion>
<FileVersion>10.1.3.0</FileVersion>
<SynchReleaseVersion>false</SynchReleaseVersion>
<StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
<DebugType>embedded</DebugType>
Expand Down