Add support for 'Default' SameSite cookie property (#14637)#3151
Merged
Add support for 'Default' SameSite cookie property (#14637)#3151
Conversation
Previously, unknown or unspecified SameSite values were mapped to 'None', which caused issues when browsers (especially Firefox via BiDi) returned cookies with default SameSite behavior. Setting SameSite=None requires Secure=true, so re-setting or deleting such cookies would fail. This adds 'Default' as a new SameSite enum value and handles it correctly: - BiDi: maps to/from CookieSameSiteValue.Default - CDP: converts to null (omitted) so the browser applies its default behavior Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defaultto theSameSiteenum to represent cookies with browser-default SameSite behaviorSameSite.Defaultinstead ofSameSite.NoneSameSite.Defaulttonull(omitted), letting the browser apply its default behaviorSameSite.DefaultUpstream PR: puppeteer/puppeteer#14637
Closes #3151
Test plan
ShouldProperlyReportDefaultSameSiteCookieShouldReportDefaultSameSiteCookieWhenNotSpecifiedShouldBeAbleToDeleteDefaultSameSiteCookie🤖 Generated with Claude Code