Unite with Gnome Shell 3.36

[galen1423]

Hello,

Thanx for this wonderfull extension.

With Ubuntu 20.04 & G.S 3.35.91, unfortunately, Unite no longer work anymore...
TypeError: controls.reparent is not a function

[TheAifam5]

ArchLinux rolled the 3.36.0 out to public. Any update on this issue?

[Zeph33]

Replace in panel.js controls.reparent(this.container) by this code

    const parent = controls.get_parent();
    if (parent) {
        parent.remove_child(controls);
    }
    this.container.add_child(controls);    

No error but dash not visible :(

[jonian]

Thanks for the reports. I'm on Arch too. I will update and try to fix the issue soon.

[jonian]

I have pushed a fix in master branch. Can you try it and confirm that it works?

[TheAifam5]

It works on my machine ™

[Zeph33]

Same issue as with my code, dash no visible
This version of Dash To Dock work for me :
https://github.com/3v1n0/dash-to-dock/tree/gnome-3-36

[jonian]

@Zeph33 How is Dash to Dock related to unite?

[Zeph33]

Replace Unite by 3 extensions"Dash to Dock" "No title Bar" and "KStatusNotifierItem/AppIndicator Support". I have tested your fix with this 3 extensions disable but the dock is not visible, no crash, no error ...

[jonian]

@Zeph33 unite is not a replacement for "Dash to Dock" and "KStatusNotifierItem/AppIndicator Support". From those extensions unite can only replace "No title Bar".

[Zeph33]

I have a lot of extension, I mixed ... your screenshot show Dash to Dock
I am sorry

[jonian]

@Zeph33 no problem.

[pezz]

Even after updating gnome-shell this morning, Unite still worked for me without that code change.

The main issue I have at the moment is that tray icons aren't looking quite right.

Icons are Hexchat, Discord and Slack.

[jonian]

@pezz please open a new issue for the icons. Thanks.

[pezz]

Done #156

[subliminal-one]

Hello,

Running Arch here and after the latest update it seems unite will only work in an X session. In Wayland the error comes up is unite_hardpixel.eu has error: TypeError: object is null.

Thanks

[ivan-masich]

I have pushed a fix in master branch. Can you try it and confirm that it works?

It works, thx!

[radiomike]

On Arch with 3.36 on Wayland and getting same error as subliminal-one. Journal excerpt for the error below.

JS ERROR: Extension unite@hardpixel.eu: TypeError: object is null
registerHandler@/home/radiomike/.local/share/gnome-shell/extension/unite@hardpixel.eu/handlers.js:59:9
connect@/home/radiomike/.local/share/gnome-shell/extensions/unite@hardpixel.eu/handlers.js:71:17
[_init@/home/radiomike/.local/share/gnome-shell/extensions/unite@hardpixel.eu/layout.js:76:20]
_init@/home/radiomike/.local/share/gnome-shell/extensions/unite@hardpixel.eu/extension.js:12:28
enable@/home/radiomike/.local/share/gnome-shell/extensions/unite@hardpixel.eu/extension.js:39:18
_callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:160:32
loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:311:26
_loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:536:18
collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:27:17
_loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:515:19
_enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:545:18
_sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:576:18
init@resource:///org/gnome/shell/ui/extensionSystem.js:54:14
_initializeUI@resource:///org/gnome/shell/ui/main.js:244:22
start@resource:///org/gnome/shell/ui/main.js:138:5
@<main>:1:47

[jonian]

@subliminal-one, @radiomike I can reproduce the issue. I will push a fix soon. Thanks for the reports.

[jonian]

@subliminal-one, @radiomike the fix is available on master branch.

[subliminal-one]

@jonian working, thanks!