Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tray icon problems #171

Closed
barkap opened this issue Apr 25, 2020 · 12 comments
Closed

Tray icon problems #171

barkap opened this issue Apr 25, 2020 · 12 comments

Comments

@barkap
Copy link

barkap commented Apr 25, 2020

unite-icon-problem

Icons: Nextcloud, Dropbox, Telegram, HexChat, QOwnNotes, Flameshot, Micorosft Teams, Discrod

I saw #160, it was closed with no comments, same problem with the latest version (v40 with default settings). Mostly Qt applications are affected (discoloration and white background) although there are some other icons with different heights as well.

gnome-shell-extension-unite 40 (arch aur package)
Manjaro 20.0
GNOME 3.36.1
HiDPI display on Wayland (same bug on Xorg)
All other extensions disabled

@skluthe
Copy link

skluthe commented Apr 29, 2020

I'm experiencing this with Barrier as well. A temporary solution until this is fixed would be allowing us to hide icons we don't want shown.

@jonian
Copy link
Member

jonian commented Apr 30, 2020

Hi @barkap, I cant reproduce this on Arch Linux (I don't have a HiDPI display to test). Try disabling all other extensions and use default gnome theme and icon theme.

Hi @skluthe, I do not intend do add such feature. I you want to implement it, I will happily accept a PR.

@skluthe
Copy link

skluthe commented Apr 30, 2020 via email

@jonian
Copy link
Member

jonian commented Apr 30, 2020

@skluthe, I'm very busy with work related projects, so I don't have the time to setup a VM now, sorry.

Have you tested with other top-icons extensions? Do they have the same problem?

Also, unite does not render the tray icons, they are rendered by gnome-shell as you can see here.

@skluthe
Copy link

skluthe commented Apr 30, 2020 via email

@tiotrom
Copy link

tiotrom commented May 2, 2020

This is how icons look on my Manjaro with https://extensions.gnome.org/extension/1031/topicons/ installed
image
And this is how they look with the Unite extension:
image
I am using greyscale for both.

In Unite the icons are very crowded despite not having the "reduce top bar icons spacing" active. I'd say Unite should add more space between the icons and for the greyscale it should improve how it does it. For instance in TopIcons I have set the following for better visibility:

image

Maybe if you could add some controls over the icons (size, color, space) would help solve such issues.
Thanks!

@jonian
Copy link
Member

jonian commented May 2, 2020

@tiotrom, thanks for the screenshots. The rendering of the icons is the same in both extensions except unite has hard-coded settings for desaturation: 1.0 brightness: 0.2 contrast: 0.3.

@tiotrom
Copy link

tiotrom commented May 2, 2020

Maybe if you can tweak those values so the icons look more naturally. They look a bit washed out. Also, the space between them could be improved I'd say.

@barkap
Copy link
Author

barkap commented May 3, 2020

I did some testing in a virtual environment and this is what I found out:

  1. You are right @jonian, icons indeed are rendering as expected on clean Arch Linux with Gnome and with unite-shell extension enabled;
  2. By default Manjaro installs some extensions and these are enabled right after installation:
  • Dash to Dock
  • KStatusNotifierItem/AppIndicator Support
  • Pamac Updates Indicator
  • User Themes

If all these extensions are disabled and only unite is upgraded+enabled, icons are messed up (like in my original screenshot). However, if (re)enable KStatusNotifierItem/AppIndicator extension then icons are ok.

So while I cannot say where the problem is, a solution to this problem is to enable KStatusNotifierItem extension along with unite-shell. Not really a fix I think, but works for me.

@skluthe
Copy link

skluthe commented May 3, 2020 via email

@tiotrom
Copy link

tiotrom commented May 4, 2020

I can confirm on a fresh install of TROMjaro (for example), the top icons are messed up like the OP says. Basically if you only install Unite on a Gnome desktop environment, then the tray icons are messed up. It works fine with other similar extensions that enable the tray icons. I hope the developer finds the mighty bug :D.

@jonian
Copy link
Member

jonian commented Sep 15, 2021

Closing as I have not been able to reproduce this.

@jonian jonian closed this as completed Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants