-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict extension to the primary monitor #109
Conversation
…mary screen or all screens
Thank you for your contribution. Maybe you can get const Settings = Unite.imports.convenience.getSettings();
Settings.getSetting('restrict-to-primary-screen') |
Thanks, @jonian ! I was in doubt if having a setting getter inside Should I leave the signals on their respective modules? (I guess they should because they may have to work based on its value). |
@vltr Sorry for the late response. Yes, you should leave the signals on their respective modules. They are used to apply changes without restarting the shell. |
@jonian don't worry 😉
That was exactly my thought. I'll update this PR shortly after. |
…r function to take only two arguments (as it was previously)
Done. I had made this change in my computer yesterday already and the extension is running flawlessly (so far) 💪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you for contributing.
Fixes issue #61 |
It was my pleasure 😉 Thanks a lot! |
Oh, @jonian , I did not change any |
This PR basically adds the option to restrict the overall extension functionality to the primary screen (if enabled, default) or all screens (if disabled). This affects the window decorations, window buttons and application menu.