Revert "Also check the disconnect handler to really fix the error on suspend"

[jonian]

Reverts #256

[jonian]

@njsf reverting this as it stops any signal from disconnecting, you can try it by adding a log inside the if clause.

[njsf]

@njsf reverting this as it stops any signal from disconnecting, you can try it by adding a log inside the if clause.

Ok, will looking into it.

[jonian]

@njsf the issue is caused in this line. My guess is that the problem begins here, it uses Main.panel.get_children() instead of explicitly connecting to left, center and right panel boxes. If another extension adds children to Main.panel it is possible to have signal connections to objects that no longer exist. Can you try with the fix below:

activate() {
  this.signals = new Handlers.Signals()

  const boxes = [
    Main.panel._leftBox,
    Main.panel._centerBox,
    Main.panel._rightBox
  ]

  for (const box of boxes) {
    this.signals.connect(
      box, 'actor_added', this._onActorAdded.bind(this)
    )
  }

  this._onActorAdded()
}

I have already pushed this fix on master branch

[njsf]

Indeed the issue is gone. I suspect you can revert #255 also.
Thanks for looking at this

[jonian]

Thanks confirming the issue is resolved. I will keep #255 as it is just a safety check and it does not cause issues.