entity-edit #1
Merged
entity-edit #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding column names and entity validation
AungKyaw-Myint
requested review from
adhikari-suman,
hariclerry and
phurpawangchuk
adhikari-suman
approved these changes
Jul 1, 2024
hariclerry
reviewed
Jul 1, 2024
| public class AcademicResource { | ||
|
|
||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private Long id; | ||
|
|
||
| @Column(name = "name", nullable = false) | ||
| private String name; | ||
| private String body; |
There was a problem hiding this comment.
Can we please use the word description instead of body?
phurpawangchuk
approved these changes
Jul 1, 2024
|
It is fine. |
hariclerry
reviewed
Jul 1, 2024
| private String name; | ||
|
|
||
| @Column(name = "body", nullable = false) | ||
| private String body; |
There was a problem hiding this comment.
Can we please use the word description instead of body here as well?
hariclerry
reviewed
Jul 1, 2024
| private LocalTime eventTime; | ||
|
|
There was a problem hiding this comment.
One more thing, is there a purpose of having these two fields separate?
private LocalDate eventDate;
private LocalTime eventTime;
I mean, can we combine them into one field?
hariclerry
reviewed
Jul 1, 2024
| private String title; | ||
|
|
||
| @Column(name = "body") | ||
| private String body; |
There was a problem hiding this comment.
Can we please use the word description instead of body here as well?
hariclerry
reviewed
Jul 1, 2024
| public class Discussion { | ||
|
|
||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private Long id; | ||
|
|
||
| @Column(name = "title", nullable = false) | ||
| private String title; | ||
| private String body; |
There was a problem hiding this comment.
Can we please use the word description instead of body here as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding column names and entity validation