Fix for livewire form properties not being found. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If anyone can confirm this works I can merge it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for nested livewire form properties not being found as discussed in issue #15. Tried to be as unobtrusive as possible. Additional reflection was not necessary since "DataStore" already holds the "BladeComponentData" for Livewire forms.
Only issue is that this fix only supports one level of nesting and the class with the nested properties must also be a Livewire component. I could have made a recursive function and implemented actual reflection for classes not found in the "availableComponents" array, but I don't think that is a good idea. This should be fine since it doesn't support bad programming practices with Livewire. Livewire properties really shouldn't be nested more than one level deep, and they really should be in a Livewire form if they are nested.
Lastly, I wanted to write a test but ran into this issue. Didn't look that deep into it but if it is a simple fix let me know.