Drop sublayers with no data even if the _subLayerProps prop contains (v…

…isgl#6160)
harisbal · Sep 3, 2021 · 202caeb · 202caeb
1 parent 5fa5dde
commit 202caeb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/docs/api-reference/core/composite-layer.md b/docs/api-reference/core/composite-layer.md
@@ -270,7 +270,7 @@ Parameters:
 * `id` (String) - the sublayer id
 * `data` (Array) - the sublayer data
 
-Returns `true` if the sublayer should be rendered. The base class implementation returns `true` if either `data` is not empty or the `_subLayerProps` prop contains override for this sublayer.
+Returns `true` if the sublayer should be rendered. The base class implementation returns `true` if `data` is not empty.
 
 
 ##### `getSubLayerClass`

diff --git a/modules/core/src/lib/composite-layer.js b/modules/core/src/lib/composite-layer.js
@@ -90,9 +90,7 @@ export default class CompositeLayer extends Layer {
 
   // Returns true if sub layer needs to be rendered
   shouldRenderSubLayer(id, data) {
-    const {_subLayerProps: overridingProps} = this.props;
-
-    return (data && data.length) || (overridingProps && overridingProps[id]);
+    return data && data.length;
   }
 
   // Returns sub layer class for a specific sublayer