pydeck: Change cell height and enable _repr_html_ in Colab (visgl#5657)

harisbal · Apr 15, 2021 · 2fbd91d · 2fbd91d
1 parent f726e84
commit 2fbd91d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/bindings/pydeck/pydeck/io/html.py b/bindings/pydeck/pydeck/io/html.py
@@ -110,7 +110,7 @@ def iframe_with_srcdoc(html_str, width="100%", height=500):
 def render_for_colab(html_str, iframe_height):
     from IPython.display import HTML, Javascript  # noqa
 
-    js_height_snippet = "google.colab.output.setIframeHeight(0, true, {maxHeight: %s})" % iframe_height
+    js_height_snippet = f"google.colab.output.setIframeHeight({iframe_height}, true, {{minHeight: {iframe_height}}})"
     display(Javascript(js_height_snippet))  # noqa
     display(HTML(html_str))  # noqa
 
@@ -153,7 +153,7 @@ def deck_to_html(
 
     if notebook_display and in_google_colab:
         render_for_colab(html_str, iframe_height)
-        return
+        return html_str
     elif not filename and as_string:
         return html_str
     elif notebook_display:

diff --git a/bindings/pydeck/setup.py b/bindings/pydeck/setup.py
@@ -124,12 +124,20 @@ def run(self):
         if build_all:
             log.info("Installing build dependencies with yarn. This may take a while...")
             check_call(
-                ["yarn", "bootstrap"], cwd=yarn_root, stdout=sys.stdout, stderr=sys.stderr, env=env,
+                ["yarn", "bootstrap"],
+                cwd=yarn_root,
+                stdout=sys.stdout,
+                stderr=sys.stderr,
+                env=env,
             )
         else:
             log.info("Installing build dependencies with `npm run build`.")
             check_call(
-                ["npm", "run", "build"], cwd=widget_dir, stdout=sys.stdout, stderr=sys.stderr, env=env,
+                ["npm", "run", "build"],
+                cwd=widget_dir,
+                stdout=sys.stdout,
+                stderr=sys.stderr,
+                env=env,
             )
 
         self.clean_frontend_build()
@@ -185,6 +193,7 @@ def run(self):
         author_email="ajduberstein@gmail.com",
         url="https://github.com/visgl/deck.gl/tree/master/bindings/pydeck",
         keywords=["data", "visualization", "graphics", "GIS", "maps"],
+        python_requires=">=3.7",
         classifiers=[
             "Intended Audience :: Developers",
             "Intended Audience :: Science/Research",