Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add config.auth param to provide basic auth credentials #55

Merged
merged 1 commit into from
May 1, 2023

Conversation

zZeepo
Copy link
Contributor

@zZeepo zZeepo commented May 1, 2023

Description

Adds the config.auth parameter to the configuration options.
If provided this parameter will authorize requests to the site with via basic auth.

Linked Issues

none

Additional context

none

@netlify
Copy link

netlify bot commented May 1, 2023

Deploy Preview for unlighthouse canceled.

Name Link
🔨 Latest commit ea9dfe7
🔍 Latest deploy log https://app.netlify.com/sites/unlighthouse/deploys/644fe85929ee3b0007e62f93

@zZeepo zZeepo force-pushed the feature/basic-auth branch from b706454 to ea9dfe7 Compare May 1, 2023 16:27
@harlan-zw
Copy link
Owner

Nice job! Looks good to me, thanks :)

@harlan-zw harlan-zw merged commit bdb89ec into harlan-zw:main May 1, 2023
@zZeepo
Copy link
Contributor Author

zZeepo commented May 1, 2023

@harlan-zw ahh sh*t.. you're too quick.
I had just discovered a minor issue with the regex in the util.ts and was added a patch for that.
I'll create a new PR for that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants