Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove await on muxing methods #16

Merged
merged 8 commits into from
Aug 4, 2023

Conversation

harlanx
Copy link
Owner

@harlanx harlanx commented Jul 30, 2023

fix:

  • Remove await on _processVideo to restore parallel processing
    this bug was introduced by fix: Missing await on future methods #2. Awaiting futures depends on usage, _processVideo in mergeMethodA should not be awaited but _processVideo in mergeMethodB should be awaited.

feat:

  • Use new pattern to split title for possible episode title
  • Make Remove Chapter & Remove Attachments conditional
    to only show when there are embedded tracks of it

chore:

  • Refactor unawaited future
  • Refactor AppBar local variables
  • Add new replaceables for default textmodifiers
  • Update dependencies and custom widgets
  • Update documentation
  • Bump app version to 0.6.2+21

@harlanx harlanx merged commit e3cf043 into main Aug 4, 2023
@harlanx harlanx deleted the bugfix/-remove-await-on-merging-methods branch August 4, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant