Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #122, some changes and MediaRouteButton fix #124

Merged
merged 6 commits into from
May 12, 2023
Merged

Issue #122, some changes and MediaRouteButton fix #124

merged 6 commits into from
May 12, 2023

Conversation

PhantomPainX
Copy link
Contributor

@PhantomPainX PhantomPainX commented Apr 12, 2023 •
edited
Loading

iOS issue #122 fixed

  • I removed unused willResignObserver from CapacitorVideoPlayerPlugin.Observers.swift

iOS new feature

  • Added a function to convert SRT subtitles to VTT in case there's any. It allows compatibility to these subtitles

Added currentTime to jeepCapVideoPlayerExit

  • It can be used if you want to know the currentTime of the player when the user exists

Android fixes

@jepiqueau jepiqueau merged commit 4d0ffee into harmonwood:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhantomPainX @jepiqueau