Skip check when the 100% check is achieved. (#4625)

* fix(consensus): skip is all collected

* fix(consensus): add the IsAllSigsCollected

* fix(consensus): remove consensus.decider.IsAllSigsCollected()

* fix(consensus): remove code

consensus/consensus_v2.go

@@ -178,7 +178,10 @@ func (consensus *Consensus) finalCommit() {
 		return
 	}
 	consensus.getLogger().Info().Hex("new", commitSigAndBitmap).Msg("[finalCommit] Overriding commit signatures!!")
-	consensus.Blockchain().WriteCommitSig(block.NumberU64(), commitSigAndBitmap)
+
+	if err := consensus.Blockchain().WriteCommitSig(block.NumberU64(), commitSigAndBitmap); err != nil {
+		consensus.getLogger().Warn().Err(err).Msg("[finalCommit] failed writting commit sig")
+	}
 
 	// Send committed message before block insertion.
 	// if leader successfully finalizes the block, send committed message to validators

consensus/leader.go

@@ -285,14 +285,6 @@ func (consensus *Consensus) onCommit(recvMsg *FBFTMessage) {
 	//// Read - Start
 	viewID := consensus.getCurBlockViewID()
 
-	if consensus.decider.IsAllSigsCollected() {
-		logger.Info().Msg("[OnCommit] 100% Enough commits received")
-		consensus.finalCommit()
-
-		consensus.msgSender.StopRetry(msg_pb.MessageType_PREPARED)
-		return
-	}
-
 	quorumIsMet := consensus.decider.IsQuorumAchieved(quorum.Commit)
 	//// Read - End