Rosetta Implementation - pt1 (Stage 3.1 of Node API Overhaul) #3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update go.mod for rosetta SDK Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Daniel-VDM
changed the title
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
* Make go.mod changes minimal Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Daniel-VDM
force-pushed
the
rosetta-server-impl
branch
from
28b386b to
e046938
Compare
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Daniel-VDM
changed the title
JackyWYX
reviewed
Aug 13, 2020
There was a problem hiding this comment.
-
Since we are adding new ports, we should do our best try not to collide our port with well-known services. 10000 is binded with NDMP (https://www.snia.org/ndmp). Can we use another one?
-
You need to consider the backward compatibility of the harmonyConfig structure (It's dumped to the config file along with a version). My suggestions are:
- Increase the version to v1.1.0. (Preferred to import the version module from libp2p)
- If user are still using old version , recommend user to upgrade to config v1.1.0 with command
./harmony dumpconfig harmony.conf - Add a unit test case to make sure the data loaded from v1.0.0 config file is expected.
rlan35
reviewed
Aug 13, 2020
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
* Included update message if old config is loaded Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
|
rlan35
approved these changes
Aug 14, 2020
Signed-off-by: Daniel Van Der Maden <dvandermaden0@berkeley.edu>
Daniel-VDM
force-pushed
the
rosetta-server-impl
branch
from
05d69ae to
8707e7e
Compare
Daniel-VDM
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stage 3.1 of Node API Overhaul
This PR adds the rosetta server to the node program. The rosetta server is hosted on port 9700 by default on an explorer node. Other nodes can enable rosetta it if they wish, but by default, it is off for all validator nodes.
This PR also outlines the structure of the
rosettapackage to follow the example provided here.The server was tested using rosetta's example client here and passes.
In order to use rosetta's SDK, we must use go-ethereum v1.9.18. As this is not compatible with our current code, I've added a replace in the go.mod file to support go-ethereum v1.8.27 as well. I've also updated/cleaned up the relative packages needed for rosetta's SDK.