[config] Add p2p.disc.concurrency flag #3829
Conversation
| @@ -54,6 +54,8 @@ const ( | |||
| DefaultWSPort = 9800 | |||
| // DefaultPrometheusPort is the default prometheus port. The actual port used is 9000+900 | |||
| DefaultPrometheusPort = 9900 | |||
| // DefaultP2PConcurrency is the default P2P concurrency, 0 means is set the default value of P2P Discovery, the actual value is 10 | |||
There was a problem hiding this comment.
what is the default value from libp2p?
There was a problem hiding this comment.
comment mentioned, 10 is default
|
please fix travis test. |
cmd/harmony/config_migrations.go
Outdated
| @@ -103,6 +103,10 @@ func init() { | |||
| confTree.Set("P2P.IP", defaultConfig.P2P.IP) | |||
| } | |||
|
|
|||
| if confTree.Get("P2P.Concurrency") == nil { | |||
There was a problem hiding this comment.
This is a new field, and you need to update the config version. Also it is recommended that you rebase on top of #3773
There was a problem hiding this comment.
need to wait the PR you mentioed merged, and I can rebase on the top of the PR. Otherwise this PR may still be changed
cmd/harmony/flags.go
Outdated
| @@ -513,6 +513,11 @@ var ( | |||
| DefValue: defaultConfig.P2P.KeyFile, | |||
| Deprecated: "use --p2p.keyfile", | |||
| } | |||
| p2pDiscoveryConcurrencyFlag = cli.IntFlag{ | |||
| Name: "p2p.concurrency", | |||
There was a problem hiding this comment.
Suggest p2p.disc.concurrency. p2p.concurrency is too general
p2p/discovery/discovery.go
Outdated
| @@ -42,6 +42,13 @@ func NewDHTDiscovery(host libp2p_host.Host, opt DHTConfig) (Discovery, error) { | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Suggest move to getLibp2pRawOptions
AlexiaChen
changed the title
AlexiaChen
force-pushed
the
config-concurrency
branch
from
b08947d to
1bf1a53
Compare
Removed downgrade kad-dht code in |
AlexiaChen
force-pushed
the
config-concurrency
branch
from
1bf1a53 to
2f8dd26
Compare
This reverts commit af7e0de.
Issue
Because of the block time problem of all shards, the parameter of concurrency needs to be exposed for adjustment. If it is set to 1, it may currently go wrong and affect the consensus. Set to 1, according to the paper, KAD DHT query time will downgrade to Chord‘s algorithm
NOTE： Add p2p.disc.concurrency flag and default value with libp2p dht
Test
Passed Local test