Feature: generating protoflles with docker. #4427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i guess two things we can do here :
|
|
ONECasey
approved these changes
May 20, 2023
MaxMustermann2
added a commit
to MaxMustermann2/harmony
that referenced
this pull request
Jun 28, 2023
With harmony-one#4427, the protofiles are generated using a Docker image and thus `protoc` related binaries are not required. However, `mockgen` and `golangci-lint` are still being used by our Travis build. This change restores the file that installs them, and removes `protoc` related files from the list of installations.
MaxMustermann2
added a commit
to MaxMustermann2/harmony
that referenced
this pull request
Jun 28, 2023
With harmony-one#4427, the protofiles are generated using a Docker image and thus `protoc` related binaries are not required. However, `mockgen` and `golangci-lint` are still being used by our Travis build. This change restores the file that installs them, and removes `protoc` related files from the list of installations.
ONECasey
pushed a commit
that referenced
this pull request
Jun 28, 2023
With #4427, the protofiles are generated using a Docker image and thus `protoc` related binaries are not required. However, `mockgen` and `golangci-lint` are still being used by our Travis build. This change restores the file that installs them, and removes `protoc` related files from the list of installations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protofiles generated by developers with different versions of proto, gen-go-grpc and protoc-gen-go. This PR aims to unify process of generating by using same version saved in the docker image.
I contains test that checks generated output and fails if it's not generate by image.
Only 1 concern here - i use my own repo for image frozen621/harmony-proto:latest, because i don't have access to harmony docker hub.