Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with port already in use. #4548

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Fixed bug with port already in use. #4548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions p2p/security/security_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package security
import (
"context"
"fmt"
"net"
"testing"
"time"

Expand Down Expand Up @@ -53,8 +54,26 @@ func (mh *fakeHost) SetDisconnectCallback(callback DisconnectCallback) {
mh.onDisconnects = append(mh.onDisconnects, callback)
}

func GetFreePort(t *testing.T) int {
t.Helper()
a, err := net.ResolveTCPAddr("tcp", "localhost:0")
if err != nil {
t.Fatal(err)
return 0
} else {
l, err := net.ListenTCP("tcp", a)
if err != nil {
t.Fatal(err)
return 0
} else {
defer l.Close()
return l.Addr().(*net.TCPAddr).Port
}
}
}

func TestManager_OnConnectCheck(t *testing.T) {
h1, err := newPeer(50550)
h1, err := newPeer(GetFreePort(t))
require.NoError(t, err)
defer h1.Close()

Expand All @@ -63,7 +82,7 @@ func TestManager_OnConnectCheck(t *testing.T) {
h1.Network().Notify(fakeHost)
fakeHost.SetConnectCallback(security.OnConnectCheck)
fakeHost.SetDisconnectCallback(security.OnDisconnectCheck)
h2, err := newPeer(50551)
h2, err := newPeer(GetFreePort(t))
assert.Nil(t, err)
defer h2.Close()
err = h2.Connect(context.Background(), peer.AddrInfo{ID: h1.ID(), Addrs: h1.Network().ListenAddresses()})
Expand All @@ -74,7 +93,7 @@ func TestManager_OnConnectCheck(t *testing.T) {
return true
})

h3, err := newPeer(50552)
h3, err := newPeer(GetFreePort(t))
assert.Nil(t, err)
defer h3.Close()
err = h3.Connect(context.Background(), peer.AddrInfo{ID: h1.ID(), Addrs: h1.Network().ListenAddresses()})
Expand All @@ -84,7 +103,7 @@ func TestManager_OnConnectCheck(t *testing.T) {
return true
})

h4, err := newPeer(50553)
h4, err := newPeer(GetFreePort(t))
assert.Nil(t, err)
defer h4.Close()
err = h4.Connect(context.Background(), peer.AddrInfo{ID: h1.ID(), Addrs: h1.Network().ListenAddresses()})
Expand All @@ -96,7 +115,7 @@ func TestManager_OnConnectCheck(t *testing.T) {
}

func TestManager_OnDisconnectCheck(t *testing.T) {
h1, err := newPeer(50550)
h1, err := newPeer(GetFreePort(t))
assert.Nil(t, err)
defer h1.Close()

Expand All @@ -105,7 +124,7 @@ func TestManager_OnDisconnectCheck(t *testing.T) {
h1.Network().Notify(fakeHost)
fakeHost.SetConnectCallback(security.OnConnectCheck)
fakeHost.SetDisconnectCallback(security.OnDisconnectCheck)
h2, err := newPeer(50551)
h2, err := newPeer(GetFreePort(t))
assert.Nil(t, err)
defer h2.Close()
err = h2.Connect(context.Background(), peer.AddrInfo{ID: h1.ID(), Addrs: h1.Network().ListenAddresses()})
Expand Down