Rollback removes physically block data from db. #4568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ONECasey
approved these changes
Nov 21, 2023
|
I believe merely deleting the block physically may not suffice for a rollback. We need to consider the rollback of states, the explorer database, and for s0, the rollback of stored crosslinks. There may be more DBs to consider. f we merge this PR, what would be the impact or doing a rollback without reverting the previously suggested DBs As discussed in our recent meeting, the current state of the rollback should only be used in cases where the node has forked or gotten stuck, and a rollback of just one block is sufficient to restore the node. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback removes physically block data from db.