Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: last signing power. #4584

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Feature: last signing power. #4584

merged 3 commits into from
Dec 20, 2023

Conversation

Frozen
Copy link
Contributor

@Frozen Frozen commented Dec 11, 2023

Calculation on last inserted block, no leader required.

@Frozen Frozen self-assigned this Dec 11, 2023
@Frozen Frozen added the WIP Work in progress don't merge yet! label Dec 11, 2023
@Frozen Frozen removed the WIP Work in progress don't merge yet! label Dec 14, 2023
@ONECasey ONECasey merged commit 556444c into dev Dec 20, 2023
4 checks passed
@diego1q2w diego1q2w deleted the feature/last-signing-power2 branch December 21, 2023 16:34
@sophoah
Copy link
Contributor

sophoah commented Feb 7, 2024

the last signing power is a good to have feature, however I am interested in the current signing power. During the multiple outages we had in the past, knowing how much voting power trying to sign the latest block proposed help for troubleshooting. Only the leader has that information currently.

with that PR, all validator could query for the last block total vote but not the current

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants