Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] - CI - update macos from 12 to 13, sync the CI steps for macos #4792

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

mur-me
Copy link
Collaborator

@mur-me mur-me commented Nov 6, 2024

Issue

We have a deprecation warning for the macos12, so we need to update to the new one.
After lurking the issue I found that the new Intel based Macos 14-15 will be

So my idea was to just update to the macos13, it is still regular github actions runner.

Test

  1. I've uploaded artifact via Github action job - https://github.com/mur-me/harmony/actions/runs/11688454932/job/32548949803,
  2. Link to download is https://github.com/mur-me/harmony/actions/runs/11688454932/artifacts/2147768551
  3. Used MacBook Air Intel with MacOS - 15.0.1
  4. Installed harmony and libs on it, used explorer config to start
  5. Checked the logs and as you can see harmony started to sync:
{"level":"info","epoch":"2938","size":1375,"caller":"/Users/runner/work/harmony/harmony/harmony/core/rawdb/accessors_offchain.go:46","time":"2024-11-06T18:07:38.312901+03:00","message":"wrote sharding state, epoch 2938"}
{"level":"info","caller":"/Users/runner/work/harmony/harmony/harmony/core/epochchain.go:169","time":"2024-11-06T18:07:38.313151+03:00","message":"[EPOCHSYNC] Added block 24051787, epoch 2937, 0xe87972c979e7f42a9943ee9d04dde4522c98a8f87b0f9f982814ff149a7dee9b"}
{"level":"info","epoch":"2939","size":1375,"caller":"/Users/runner/work/harmony/harmony/harmony/core/rawdb/accessors_offchain.go:46","time":"2024-11-06T18:07:38.315394+03:00","message":"wrote sharding state, epoch 2939"}
{"level":"info","caller":"/Users/runner/work/harmony/harmony/harmony/core/epochchain.go:169","time":"2024-11-06T18:07:38.3156+03:00","message":"[EPOCHSYNC] Added block 24059979, epoch 2938, 0xc3fbd5ef6320a9d0989a04da0436da660bfd1c01e834c2a1268eeaedbab5852c"}

Result: we can use macos13 runner until it deprecated and removed by Github 

Unit Test Coverage

Before:

<!-- copy/paste 'go test -cover' result in the directory you made change -->

After:

<!-- copy/paste 'go test -cover' result in the directory you made change -->

Test/Run Logs

Operational Checklist

  1. Does this PR introduce backward-incompatible changes to the on-disk data structure and/or the over-the-wire protocol?. (If no, skip to question 8.)

    YES|NO

  2. Describe the migration plan.. For each flag epoch, describe what changes take place at the flag epoch, the anticipated interactions between upgraded/non-upgraded nodes, and any special operational considerations for the migration.

  3. Describe how the plan was tested.

  4. How much minimum baking period after the last flag epoch should we allow on Pangaea before promotion onto mainnet?

  5. What are the planned flag epoch numbers and their ETAs on Pangaea?

  6. What are the planned flag epoch numbers and their ETAs on mainnet?

    Note that this must be enough to cover baking period on Pangaea.

  7. What should node operators know about this planned change?

  8. Does this PR introduce backward-incompatible changes NOT related to on-disk data structure and/or over-the-wire protocol? (If no, continue to question 11.)

    YES|NO

  9. Does the existing node.sh continue to work with this change?

  10. What should node operators know about this change?

  11. Does this PR introduce significant changes to the operational requirements of the node software, such as >20% increase in CPU, memory, and/or disk usage?

TODO

@mur-me mur-me changed the title [fix] - update macos from 12 to 13, sync the CI steps for macos [fix] - CI - update macos from 12 to 13, sync the CI steps for macos Nov 6, 2024
@sophoah sophoah merged commit 9f66e34 into dev Nov 7, 2024
4 checks passed
@mur-me mur-me deleted the fix_ci_update_to_macos13 branch November 7, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants