#11 Expose option of turning on/off negation behaviour through the API #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Question negation is language specific but not always wanted. This PR is to enable/disable it at the
match_instruments
endpoint in conjunction with the issue harmonydata/harmony#59 in the Python library.To clarify, there are some rule based scripts here which turn "I like" into "I don't like" etc in English and a few other languages. This is hard coded and some users want to be able to turn it off. In this PR I added a switch at library level and also at API level which stops the functions in
negator.py
being called. This PR is to expose the switch as an option in the API.Fixes # (issue)
Type of change
Please delete options that are not relevant.
Testing
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
test_negate_local.py
Test Configuration
Python 3.11.0rc1
Checklist