Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min_value and max_value slash command options #262

Merged

Conversation

invalidCards
Copy link
Contributor

About

Newly added by Discord to add minimum and maximum value constraints to NUMBER and INTEGER slash command options. See also https://discord.com/developers/docs/interactions/application-commands#application-command-object-application-command-option-structure

Status

  • These changes have been tested against Discord API or do not contain API change.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

Copy link
Member

@DjDeveloperr DjDeveloperr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DjDeveloperr
Copy link
Member

(Canary CI failing is unrelated to PR)

Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DjDeveloperr
Copy link
Member

Merge upstream main branch to fix canary CI @invalidCards

@DjDeveloperr DjDeveloperr merged commit 46bcfed into harmonyland:main Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants