Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Incorrect permissions in the member object & in commands #340

Merged
merged 2 commits into from
Feb 26, 2023
Merged

Fix: Incorrect permissions in the member object & in commands #340

merged 2 commits into from
Feb 26, 2023

Conversation

Blocksnmore
Copy link
Contributor

About

This pr fixes:

  • Guild Owner getting a permission error when executing a command
  • Member object always returns default permissions and doesn't include role permissions

Note

It's possible that the perms might desync if roles get modified. Feel free to let me know where/how I should implement a fix for that.

Status

  • These changes have been tested against Discord API or do not contain API change.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

Helloyunho
Helloyunho approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Helloyunho Helloyunho merged commit cb9a2d4 into harmonyland:main Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Helloyunho Helloyunho Helloyunho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Blocksnmore @Helloyunho