Add command cooldowns #346
Conversation
src/commands/client.ts
Outdated
| const commandCanBeUsedAt = | ||
| (userCooldowns.commands[command.name] ?? 0) + | ||
| ((command.cooldown ?? 0) as number) | ||
| const globalCooldown = userCooldowns.global + this.cooldown |
There was a problem hiding this comment.
shouldn't one of them override the cooldown or am I reading the code wrong?
There was a problem hiding this comment.
I personally felt that it makes more sense to have the cooldowns separate so that you don't have a minute global cooldown from running one command.
There was a problem hiding this comment.
but it adds the command cooldown with the global cooldown...
There was a problem hiding this comment.
this.cooldown is the global cooldown being set in the client, command.cooldown is set in each individual command.
There was a problem hiding this comment.
my 2 cents:
global cooldown should prevent any user from running command x before the cooldown expires.
For example: resource heavy commands and/or for minigames like having a command that can only be redeemed by one person every y hours.
/**
* Defines a cooldown in miliseconds, preventing the same user from running the command within the cooldown period
**/
command.cooldown?: number
/**
* Defines a global cooldown in miliseconds, preventing any user from running the command within the cooldown period
**/
command.globalCooldown?:numberThere was a problem hiding this comment.
my 2 cents: global cooldown should prevent any user from running command
xbefore the cooldown expires.For example: resource heavy commands and/or for minigames like having a command that can only be redeemed by one person every
yhours./** * Defines a cooldown in miliseconds, preventing the same user from running the command within the cooldown period **/ command.cooldown?: number /** * Defines a global cooldown in miliseconds, preventing any user from running the command within the cooldown period **/ command.globalCooldown?:number
I've added the global cooldowns and also renamed the previous cooldown to hopefully reduce confusion in regards to what it applies to.
Added the globalCooldown property for a bot wide cooldown and renamed the previous cooldown variable to hopefully reduce confusion
About
This command adds the
commandOnCooldownevent, along with acooldownproperty on bothCommandClientandCommandStatus