Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Inline Replies #37

Merged
merged 2 commits into from
Nov 19, 2020
Merged

feature: Inline Replies #37

merged 2 commits into from
Nov 19, 2020

Conversation

DjDeveloperr
Copy link
Member

In this PR, I have,

  • Implemented Inline Replies (refer to Inline Replies discord/discord-api-docs#2118). Message#reply was changed to use Inline Replies instead, but keep in mind - this feature is slowly rolling out, so it may throw 403 - Missing Access!
  • Fixed unexpected behavior with REST Manager. Now handles status codes correctly.

@DjDeveloperr
Copy link
Member Author

image

Tests failing when setting up Deno 🤔

@AkiaCode AkiaCode added enhancement ✨ New feature or request help wanted 😕 Extra attention is needed labels Nov 17, 2020
Helloyunho
Helloyunho reviewed Nov 19, 2020
View reviewed changes
Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not bad, but make types as any doesn't seem like a good idea.

Still, I'll merge it because I probably can fix it.

@Helloyunho Helloyunho merged commit ce44463 into harmonyland:main Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Helloyunho Helloyunho Helloyunho left review comments

Assignees

@Helloyunho Helloyunho

Labels
enhancement ✨ New feature or request help wanted 😕 Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DjDeveloperr @Helloyunho @AkiaCode