PipelineGraph and Pipeline Studio visual view integration #532
+5,585
−650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for harness-xd-review ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
srdjan-harness
force-pushed
the
pipeline-graph-v3
branch
2 times, most recently
from
a962365 to
38bb051
Compare
srdjan-harness
force-pushed
the
pipeline-graph-v3
branch
from
c04b0d7 to
f659ecb
Compare
srdjan-harness
changed the title
abhinavrastogi-harness
force-pushed
the
pipeline-graph-v3
branch
from
462aa64 to
161bcd2
Compare
abhinavrastogi-harness
approved these changes
Jan 6, 2025
| } | ||
|
|
||
| /** split path of item to 1. path to array and 2. element index */ | ||
| export function getPathPeaces(path: string) { |
There was a problem hiding this comment.
nit: typo getPathPieces
| import { ContainerNode } from '../types/nodes' | ||
| import { AnyNodeInternal, ParallelNodeInternalType, SerialNodeInternalType } from '../types/nodes-internal' | ||
|
|
||
| export function getThreeDepth(node: AnyNodeInternal): number { |
There was a problem hiding this comment.
nit: typo getTreeDepth
| // TODO | ||
| style={{ | ||
| border: '1px solid #454545', | ||
| background: 'linear-gradient(-47deg, rgba(152, 150, 172, 0.05) 0%, rgba(177, 177, 177, 0.15) 100%)' |
There was a problem hiding this comment.
@srdjan-harness lets move this to a tailwind utility class once you're back.
vardanbansal-harness
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.