FFM-7325 - Improve authentication retry logic #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What Harden the authentication retry logic to only retry on certain HTTP codes, certain error codes will be treated as transient and others not. We also want to ensure that while we are authenticating that default values will be served. Why We're doing a genernal review of network resiliency on auth and hardening code. Testing Manual + new unit tests added
|
✅ Linked to Story FFM-7325 · Ruby SDK - Retry on Client Authentication failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FFM-7325 - Improve authentication retry logic
What
Harden the authentication retry logic to only retry on certain HTTP codes, certain error codes will be treated as transient and others not. We also want to ensure that while we are authenticating that default values will be served.
Why
We're doing a genernal review of network resiliency on auth and hardening code.
Testing
Manual + new unit tests added