FFM-8670: Feature flag rule not being evaluated for a given attribute #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribeirophillipe
force-pushed
the
FFM-8670
branch
7 times, most recently
from
0f0b044 to
e5aa9ba
Compare
* Fix evaluation issue where a boolean is returned instead of a value * Include test case
ribeirophillipe
force-pushed
the
FFM-8670
branch
from
e5aa9ba to
db8934c
Compare
andybharness
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix evaluation issue where a boolean is returned instead of a value. In the issue FFM-8670, the customer reported that flag was still returning the same true value, even though the flag was set and that boolean is compared against the list of IN clause values from the flag’s config, which always fails.