Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FFM-8725] - Target attributes need to be defined as a hash instead of an array #29

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

andybharness
Copy link
Contributor

@andybharness andybharness commented Jul 20, 2023

FFM-8725 - Target attributes need to be defined as a hash instead of an array

What
Set attributes to hash instead of array when none are given

Why
The following exception is seen when rules are defined with an empty set of attributes:
evaluator.rb:148:in `get_attr_value': no implicit conversion of Symbol into Integer (TypeError)

Testing
New test added to TestEvaluations_ServerSDK see FFM-8706

…f an array

What
Set attributes to hash instead of array when none are given

Why
The following exception is seen when rules are defined with an empty set of attributes:
  evaluator.rb:148:in `get_attr_value': no implicit conversion of Symbol into Integer (TypeError)

Testing
New test added to TestEvaluations_ServerSDK see [FFM-8706]
@andybharness andybharness merged commit d731887 into main Jul 20, 2023
@andybharness andybharness deleted the FFM-8725-fix-attrs-empty-init branch July 20, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants