Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFM-9804 Fix percentage rollout prefix #31

Merged
merged 3 commits into from
Nov 7, 2023
Merged

FFM-9804 Fix percentage rollout prefix #31

merged 3 commits into from
Nov 7, 2023

Conversation

erdirowlands
Copy link
Contributor

What

Updates percentage rollout prefix to align with other SDKs.

Why

The prefix is backwards in this SDK, and Ruby, compared to our other SDKs.

Testing

Manual - compared hash for given target with Golang SDK

Copy link
Contributor

@andybharness andybharness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, note we'll need to increment the main version number and add a note to the release notes, just so any existing customers know that buckets may shift

@erdirowlands erdirowlands changed the base branch from main to main-v2 November 6, 2023 18:08
@erdirowlands
Copy link
Contributor Author

looks good, note we'll need to increment the main version number and add a note to the release notes, just so any existing customers know what buckets may shift

Cheers @andybharness will do that now, note I just changed the base to main-v2 there in case we need to get bug fixes in to main in the meantime. Once we are ready to release, we can merge main-v2 back

@erdirowlands erdirowlands merged commit 60555b4 into main-v2 Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants