Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [CDS-105417]: harness_platform_gitops_applications resource is n… #1142

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

mani5h-harness
Copy link
Contributor

…ot detecting drift in application manifest

Title: [Component/Feature] Short Description of the Change

Fix harness_platform_gitops_applications resource is not detecting drift in application manifest.

Summary:
Provide a brief overview of what the PR does and why it is needed.

Issue - harness_platform_gitops_applications resource is not detecting drift in application manifest.
Root cause - ref for sources was being set which is not part of the schema. ref is only used for multisource sources.
Fix - skip setting ref for app source

Details:
Explain the changes in detail, including any relevant context or background information.

Related Issues:
Reference any related issues or tickets

Testing Instructions:
Describe how the changes were tested. Include any test cases or steps to verify the functionality.
Please include the below test scenario with your changes.

  • Create the resource and execute terraform apply. (Verify the resource is created)
  • Execute terraform apply again without any changes. (Verify no changes should be done)
  • Update the resource and execute terraform apply. (Verify the resource updated successfully)
  • Remove the content from resource file and execute terraform apply. (Verify the resource has been deleted)
  • Add again the resource and execute the terraform apply. (Verify the resource is created)
  • Verify the import the resource file is working fine.
  • In case of remote entity, Verify for both default and non default branch.

Screenshots:
Include before and after screenshots to visually demonstrate the changes.
Checklist:

  • Code changes are well-documented.
  • Tests have been added/updated.
  • Changes have been tested locally.
  • Documentation has been updated.
PR Check triggers
  • Build: trigger build
  • Sub Category Field Check: trigger subcategoryfieldcheck
  • gitleaks: trigger gitleaks

@mani5h-harness mani5h-harness merged commit 8325133 into main Jan 6, 2025
3 checks passed
@mani5h-harness mani5h-harness deleted the CDS-105417 branch January 6, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants