generated from hashicorp/terraform-provider-scaffolding
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [CDS-102304]: Add private key as param when fetching deployment yaml. #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirko seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
internal/service/platform/gitops/agent_yaml/data_source_gitops_agent_deploy_yaml.go
Outdated
Show resolved
Hide resolved
internal/service/cd_nextgen/connector/codeRepositories/gitlab.go
Outdated
Show resolved
Hide resolved
… agent Signed-off-by: Mirko <mirko@harness.io>
… agent Signed-off-by: Mirko <mirko@harness.io>
… agent Signed-off-by: Mirko <mirko@harness.io>
… agent Signed-off-by: Mirko <mirko@harness.io>
… agent Signed-off-by: Mirko <mirko@harness.io>
… agent Signed-off-by: Mirko <mirko@harness.io>
Signed-off-by: Mirko <mirko@harness.io>
abosii-harness
approved these changes
Jan 17, 2025
ashinsabu3
approved these changes
Jan 17, 2025
acasian-harness
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: [Component/Feature] Short Description of the Change
Summary:
When using data_source_gitops_agent_deploy_yaml to fetch agent deployment yaml agent token gets regnerated and existing token becomes invalid making agent to get disconnect until new manifest is applied.
This PR adds private key as parm so that existing private key can be used to fetch deployment yaml without regnerating the token.
Details:
Explain the changes in detail, including any relevant context or background information.
Related Issues:
Reference any related issues or tickets
Testing Instructions:
Describe how the changes were tested. Include any test cases or steps to verify the functionality.
Please include the below test scenario with your changes.
Screenshots:
Include before and after screenshots to visually demonstrate the changes.
Checklist:
PR Check triggers
trigger build
trigger subcategoryfieldcheck
trigger gitleaks