Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [CDS-102304]: Add private key as param when fetching deployment yaml. #1149

Merged
merged 7 commits into from
Jan 17, 2025

Conversation

mteodor
Copy link
Contributor

@mteodor mteodor commented Jan 14, 2025

Title: [Component/Feature] Short Description of the Change

Summary:
When using data_source_gitops_agent_deploy_yaml to fetch agent deployment yaml agent token gets regnerated and existing token becomes invalid making agent to get disconnect until new manifest is applied.
This PR adds private key as parm so that existing private key can be used to fetch deployment yaml without regnerating the token.

Details:
Explain the changes in detail, including any relevant context or background information.

Related Issues:
Reference any related issues or tickets

Testing Instructions:
Describe how the changes were tested. Include any test cases or steps to verify the functionality.
Please include the below test scenario with your changes.

  • Create the resource and execute terraform apply. (Verify the resource is created)
  • Execute terraform apply again without any changes. (Verify no changes should be done)
  • Update the resource and execute terraform apply. (Verify the resource updated successfully)
  • Remove the content from resource file and execute terraform apply. (Verify the resource has been deleted)
  • Add again the resource and execute the terraform apply. (Verify the resource is created)
  • Verify the import the resource file is working fine.
  • In case of remote entity, Verify for both default and non default branch.

Screenshots:
Include before and after screenshots to visually demonstrate the changes.
Checklist:

  • Code changes are well-documented.
  • Tests have been added/updated.
  • Changes have been tested locally.
  • Documentation has been updated.
PR Check triggers
  • Build: trigger build
  • Sub Category Field Check: trigger subcategoryfieldcheck
  • gitleaks: trigger gitleaks

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Mirko seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Mirko added 4 commits January 16, 2025 08:52
… agent

Signed-off-by: Mirko <mirko@harness.io>
… agent

Signed-off-by: Mirko <mirko@harness.io>
… agent

Signed-off-by: Mirko <mirko@harness.io>
… agent

Signed-off-by: Mirko <mirko@harness.io>
Mirko added 3 commits January 16, 2025 09:55
… agent

Signed-off-by: Mirko <mirko@harness.io>
… agent

Signed-off-by: Mirko <mirko@harness.io>
Signed-off-by: Mirko <mirko@harness.io>
@mteodor mteodor merged commit c37682f into main Jan 17, 2025
3 checks passed
@mteodor mteodor deleted the CDS-102304 branch January 17, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants