Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option param_defs for read_grid() #22

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

pollyaschm
Copy link

@adeckmyn , as brieftly discussed, I am adding the change that made me pass the option param_defs on to read_grid().
I did this change for the read_grid() of the deterministic model only.
In my case I use this to make harp add the three variables rain+snow+graupel together to total precipitation.

@andrew-MET
Copy link
Contributor

Can I suggest changing the default from get("harp_params") to getExportedValue("harpIO", "harp_params"). I've made this change throughout harpIO as it enables it to work without having harpIO attached to the global environment.

Change default according to Andrew's recommendation
@pollyaschm
Copy link
Author

I changed the default as you recommended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants