Cannot choose merge requests if there are multiple merge requests with the same source branches

[mars90226]

Prerequsities

• I'm on the latest version of the plugin
• I've installed the required dependencies
• I've run :h gitlab.nvim.troubleshooting and followed the steps there

Setup Configuration and Environment

{
    debug = { go_request = false, go_response = false },
    popup = {
      exit = "gq",
      backup_register = "+", -- NOTE: Default backup to system register, may hinder performance in WSL
    }
  }

Bug Description

Cannot choose merge requests if there are multiple merge requests with the same source branches.

When executing :lua require('gitlab').review, gitlab.nvim will show the following error:

gitlab.nvim: Multiple MRs found: please call gitlab.choose_merge_request()

And executing :lua require('gitlab').choose_merge_request() and choose the MR, it still show the above error.

It occurs when the source branch of a merge request is deleted upon merging, and another MR is created with a newly created source branch that has the same name as the original.

I think the solution to this is to check if the merge request is merged or not and only check if the open merge requests is more than one in

gitlab.nvim/cmd/app/middleware.go

Line 123 in 38bde8a

if len(mergeRequests) > 1 {

Reproduction Steps

1. Create a MR with branch example.
2. Merge with the option "delete source branch" checked.
3. Create another MR with branch example.
4. Checkout example branch.
5. Open Neovim
6. Execute :lua require('gitlab').review() or :lua require('gitlab').choose_merge_request() and select example branch.

Screenshots

[harrisoncramer]

Hey thanks for the bug report, I was able to replicate the problem here.

I think the fix here is to pass along the internal Id (IID) of the merge request to the Go server, rather than relying on the source and target branch, when a selection is made.

This MR should solve your issue, it's now released: #398

[mars90226]

Update: :lua require('gitlab').choose_merge_request() can choose the MR now, thank you!

Thank you! I'll try if the new commit fix the bug and update here.

[harrisoncramer]

This has been merged into main so you should just be able to update the plugin normally now. It solved the issue for me 👍