Fix: Restore cursor when updating from outside of tree #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubbortlik
changed the title
jakubbortlik
changed the title
Collaborator
Author
|
I've marked this a draft because I've found a bug that this PR introduces. When data are refreshed while the discussion tree is closed, there is an error when trying to reopen the discussion tree again. I'm working on a fix. |
jakubbortlik
changed the title
Collaborator
Author
|
I've now fixed the code so that it works correctly for both discussion trees even if the cursor is outside of the discussion tree. There are some problems with test ( |
jakubbortlik
changed the title
The first branch of the `if is_draft then` block was never entered because it was inside an `if ... and not is_draft then` block.
This improves user experience by making the cursor position more predictable when modifying the discussions.
jakubbortlik
force-pushed
the
fix-restore-cursor-position-after-rebuilding-view
branch
from
532db9d to
6b53db4
Compare
Merged
harrisoncramer
added a commit
that referenced
this pull request
Nov 5, 2024
fix: parse dates without timezone offset (#404) fix: enable replying if tree is in a different tab (#407) fix: wrong get url (#413) fix: Restore cursor when updating from outside of tree (#406) --------- Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me> Co-authored-by: Oscar <oscar.creator13@gmail.com>
jakubbortlik
deleted the
fix-restore-cursor-position-after-rebuilding-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the user experience in the discussion tree by restoring cursor position after rebuilding the tree. This makes navigation in the discussion tree more fluent without the cursor jumping to the first line of the tree after actions like resolving discussions, adding new comments, publishing drafts etc.