-
Notifications
You must be signed in to change notification settings - Fork 48
Fix: add more emojis and make emoji picker configurable #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: add more emojis and make emoji picker configurable #414
Conversation
|
Sorry @jakubbortlik think I triggered a conflict for you here |
No problem, I'll fix it. |
This commit makes it possible to also show and search for the short names of emojis in the picker. Also, it makes it possible for users to fix some rendering issues stemming from conflicts in how emojis are handled in the editor/terminal/font/tmux.
ea0a275 to
2cda01d
Compare
|
Thanks for your research into this.
format_item = function(val)
if state.settings.emoji.formatter then
return state.settings.emoji.formatter(val)
end
return string.format("%s %s", val.moji, val.name)
end,This will not be used by 99% of users so I'd like to simplify it. |
This makes much more sense. I've used |
fix: Show non-resolvable notes in winbar (#417) fix: add more emojis and make emoji picker configurable (#414) fix: comment creation should not be possible for renamed and moved files (#416) fix: color highlight groups are invalid (#421) fix: plugin failing to build on Windows (#419) --------- Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
This PR adds more emojis and makes the picker configurable in the following way:
gitlab.nvimshould definitely not be fixing this mess, but I believe that adding a configurable formatting function is an acceptable price for helping users fix some of the problems (before those are fixed in the proper place, the editor, terminal, tmux,...).