Feat: Adapt winbar string to window width #435
Closed
+64
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubbortlik
commented
Nov 26, 2024
| -- Returns the input winbar string shortened to fit into the windo width. | ||
| ---@return string | ||
| local adapt_to_winwidth = function(str) | ||
| if too_long(str) then |
There was a problem hiding this comment.
The solution is not particularly elegant, but unfortunately, Lua tables do not keep order of insertion, so it's not possible to do simply something like this if we want the winbar to adapt in a predictable way:
local shortenings = {
["Inline "] = "".
[" Mode"] = "",
}
for pattern, replacement in pairs(shortenings) do
if too_long(str) then
str:gsub(pattern, replacement)
end
end
jakubbortlik
force-pushed
the
fix-adapt-winbar-string-to-window-width
branch
from
d908881 to
7ae882e
Compare
|
Hey Jakub, I actually shortened the winbar quite a bit, so I'm not sure this is still relevant -- if so, you may have to start anew from latest develop. |
|
In fact, you're probably just better off creating a new MR if you want to make changes to the winbar, I'm going to close this one out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #432 that makes sure that if the discussion tree is opened in a right split, the
winbaris not just blindly truncated from the left which would hide useful information (number of comments), but individual components of thewinbarstring are dynamically shortened to fit in the window.