Fix: Remove Retry Logic #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
@jakubbortlik I think this will prevent posting multiple notes/comments, this HTTP client has retry logic that I believe is being triggered by general HTTP errors from Gitlab: https://github.com/hashicorp/go-retryablehttp |
Collaborator
|
Nice! I haven't really tried to find a way to reproduce the issue, but I just hope it will not reappear after this fix. Thanks! |
3 tasks
harrisoncramer
added a commit
that referenced
this pull request
Jan 18, 2025
Miscellaneous bug fixes and improvements. docs: various improvements (#445) fix: don't jump to file from reviewer if it doesn't exist (#452) fix: force linewise motion in suggestion keybinding (#454) fix: prevent error after plenary job update (#456) fix: fix JSON on Windows (#458) fix: remove retry logic (#449) fix: check whether comment can be created (#434)
jakubbortlik
pushed a commit
to jakubbortlik/gitlab.nvim
that referenced
this pull request
Jan 27, 2025
Miscellaneous bug fixes and improvements. docs: various improvements (harrisoncramer#445) fix: don't jump to file from reviewer if it doesn't exist (harrisoncramer#452) fix: force linewise motion in suggestion keybinding (harrisoncramer#454) fix: prevent error after plenary job update (harrisoncramer#456) fix: fix JSON on Windows (harrisoncramer#458) fix: remove retry logic (harrisoncramer#449) fix: check whether comment can be created (harrisoncramer#434)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR changes the configuration to the HTTP client so that it doesn't retry failed attempts. This behavior was causing problems when Gitlab fails with a 500 status code, but actually publishes something.