Support symlinked executables on Windows

[charlespierce]

Info

The fix to support Windows Reparse Points in #23 inadvertently resulted in actual Windows symlinks being skipped. Since fs::symlink_metadata doesn't traverse symlinks, calling it on a symlink will result in is_file being false, cause which to incorrectly ignore the symlink.

Changes

• Added an additional check for is_symlink in the Windows branch of the ExistedChecker, which correctly includes actual symlinks as well as potentially executable.

Tested

• Created a symlink to a .exe file locally (following these steps) and confirmed that this change can detect the linked executable.
• Created a symlink to a directory and confirmed that which still correctly detects directories aren't executable.

Note

[fdncred]

@harryfei when you get a chance, can you please look at this?

[harryfei]

Sorry, I missed this PR.

[charlespierce]

@harryfei I dont think this is a breaking change. This behavior worked as expected in 4.0.0 and regressed in 4.0.1, so this is a bug fix for that regression.

[harryfei]

I will publish the new version.

[fdncred]

Thanks @harryfei !!!

[fdncred]

@harryfei Can I ask when you plan to publish this new version?

[harryfei]

@fdncred Done already. 😄

[fdncred]

@harryfei I'm confused. I just see 4.0.1 in your releases on GH. What am I missing?

[harryfei]

@fdncred Yeah, I released 4.0.2 on crates.io. Just forget to create 4.0.2 tag on GH. 😄

[fdncred]

oh, ok. thanks!