Conversation
harrynull
commented
Feb 6, 2021
harrynull
commented
- Downloads the dict file when not found
- Store it under AppData\Local (should fix dict files lost when updating plugin #2 )
- Use the updated ecdict: https://github.com/skywind3000/ECDICT-ultimate
src/DictDownloadManager.cs
Outdated
There was a problem hiding this comment.
Shouldn't this should be $"{downloadPercentage} %"?
There was a problem hiding this comment.
Ah you're right. Thanks!
|
Please move config to the same place as well, because what Flow's update is doing is that it will replace the old folder with a new folder, so config within the plugin folder won't be kept after update. |
|
The main reason I chose Local over Roaming is that I feel like the dictionary database is too large (1GB) to roam (from my understanding; I don't know if there is a formal distinction between those two folders). I definitely could move settings to there though. |
| public void Save() | ||
| { | ||
| await JsonSerializer.SerializeAsync(File.OpenWrite(ConfigFile), this); | ||
| File.WriteAllText(ConfigFile, JsonSerializer.Serialize(this)); |
There was a problem hiding this comment.
Changed it back to blocking api because there seems to be some kind of race condition otherwise.
There was a problem hiding this comment.
I think this logic should be changed later after ISavable has been migrated to Flow.Launcher.Plugin so that we shall allow the call of Save automatically by Flow. No race situation will exist after that.
There was a problem hiding this comment.
That sounds handy! Look forward to that and PluginJsonStorage class you mentioned.
There was a problem hiding this comment.
@harrynull
It is on progress.
Flow-Launcher/Flow.Launcher#341
Oh I see it. I am not sure about the difference between these two as well..... |
2 participants
