Init target-s3-jsonl #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynaim94-harrys
force-pushed
the
ynaim94/batch-write-s3-jsonl
branch
6 times, most recently
from
c3bad54 to
496c603
Compare
ynaim94-harrys
force-pushed
the
ynaim94/batch-write-s3-jsonl
branch
from
496c603 to
642c475
Compare
ynaim94-harrys
force-pushed
the
ynaim94/batch-write-s3-jsonl
branch
from
53eec51 to
cdc2397
Compare
ynaim94-harrys
force-pushed
the
ynaim94/batch-write-s3-jsonl
branch
from
41cf786 to
0b124c7
Compare
ynaim94-harrys
force-pushed
the
ynaim94/batch-write-s3-jsonl
branch
from
0b124c7 to
828dc98
Compare
|
|
||
| def _get_batch_key(self, batch_id): | ||
| path = self.config["prefix_scheme"].format( | ||
| stream_name=self.stream_name, batch_id=batch_id |
There was a problem hiding this comment.
should there be a {batch_id} here in meltano.yaml https://github.com/harrystech/target-s3-jsonl/pull/1/files#diff-6d0acc7374df2a40ec960634f967ae63128eac507abd089a68b8787e9433ddf2R22-R23 ?
There was a problem hiding this comment.
it is optional, "string".format(foo=bar) gives you "string". The user of the tap can choose whether to use the stream name of not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement target-s3-jsonl
QA
You can run:
This tap has also been tested in dev:
see https://github.com/harrystech/harrys-data-warehouse/pull/2453