Skip to content

Commit

Permalink
Revert "Log dlopen errors in opt builds (flutter#41477)" (flutter#43677)
Browse files Browse the repository at this point in the history
This reverts commit 321f801.

This didn't seem to help with debugging b/276657840. Fixes flutter/flutter#125523.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
  • Loading branch information
jiahaog authored and harryterkelsen committed Jul 20, 2023
1 parent 96fec48 commit 2ed74bb
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions fml/platform/posix/native_library_posix.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,8 @@ NativeLibrary::NativeLibrary(const char* path) {
::dlerror();
handle_ = ::dlopen(path, RTLD_NOW);
if (handle_ == nullptr) {
// TODO(jiahaog): Use FML_DLOG:
// https://github.com/flutter/flutter/issues/125523
FML_LOG(ERROR) << "Could not open library '" << path << "' due to error '"
<< ::dlerror() << "'.";
FML_DLOG(ERROR) << "Could not open library '" << path << "' due to error '"
<< ::dlerror() << "'.";
}
}

Expand Down

0 comments on commit 2ed74bb

Please sign in to comment.