Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster WKT Parser #117

Merged
merged 2 commits into from
Jun 26, 2017
Merged

Faster WKT Parser #117

merged 2 commits into from
Jun 26, 2017

Conversation

halfabrane
Copy link
Contributor

Scala's parser combinators while elegant are not fast enough for parsing, especially when used in tight loops. Replacing with fast parse which is closer to hand implemented parsing while retaining the readability and extensibility of a parser combinator.

@codecov-io
Copy link

Codecov Report

Merging #117 into master will increase coverage by 0.17%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   76.71%   76.89%   +0.17%     
==========================================
  Files          42       42              
  Lines        1396     1402       +6     
  Branches      103       98       -5     
==========================================
+ Hits         1071     1078       +7     
+ Misses        325      324       -1
Impacted Files Coverage Δ
...rc/main/scala/org/apache/spark/sql/types/WKT.scala 100% <100%> (ø) ⬆️
src/main/scala/magellan/WKTParser.scala 97.36% <96.29%> (+3.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18418cc...30c8f17. Read the comment docs.

@harsha2010 harsha2010 merged commit c0cbd46 into harsha2010:master Jun 26, 2017
@halfabrane halfabrane deleted the WKT branch June 27, 2017 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants