Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompress gzip content #262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Decompress gzip content #262

wants to merge 1 commit into from

Conversation

Forage
Copy link

@Forage Forage commented Oct 11, 2023

WBM is applying compression. "gzip;q=0, identity" as accepted-encoding is being ignored, so decompressing retrieved content.
Fixes #259.

WBM is applying compression. "gzip;q=0, identity" as accepted-encoding is being ignored, so decompressing retrieved content.
@grandpa1946
Copy link

when using this, file urls won't be decoded...

@Forage
Copy link
Author

Forage commented Oct 20, 2023

@grandpa1946 do you have an example?

@grandpa1946
Copy link

@grandpa1946 do you have an example?

sorry, i think it has to do with the windows naming scheme...

@grandpa1946
Copy link

it's kinda annoying because urls will be double encoded, but i can't do anything about that ofcourse

@Forage
Copy link
Author

Forage commented Oct 23, 2023

So there is or isn't an issue?
If there is, please provide an example because it's working nicely for me.

@grandpa1946
Copy link

So there is or isn't an issue? If there is, please provide an example because it's working nicely for me.

i don't think there is, because i think it has the same results as the previous version, sorry that i let you wait.

@VioletFlare
Copy link

Hello, I just tested this wonderful patch and I confirm that it works on ubuntu.
Thank you a thousand times! :)))
👍

@Forage
Copy link
Author

Forage commented Jan 10, 2024

This PR would become redundant if #267 (comment) is integrated into the code, as Net::HTTP decompresses automagically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some downloaded files are gzip stream
3 participants