Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to requests 2.30.0 and urllib3 2.0.1 #347

Merged
merged 1 commit into from
May 8, 2023

Conversation

pquentin
Copy link
Contributor

@pquentin pquentin commented May 8, 2023

Hello, urllib3 maintainer here 👋

#343 and #345 failed because requests had not been updated yet. Let's try to update both

Closes #343

@hartwork
Copy link
Owner

hartwork commented May 8, 2023

Hi @pquentin nice to meet you!

I've seen you help out with urllib3 >=2 transitions at multiple place, very nice! 👍 👍

I believe asking dependabot and/or CI to retry on #344 would succeed today, and then #345 would after rebase. But let's save that while you're already here with this pull request.

Unfortunately the CI in here takes ~45 minutes (due to compilation of e.g. a Linux kernel) which is why bump PRs may lay around a bit longer than in my other repos. Let's see if your PR gets green CI.

I'll see if I can finish kevin1024/vcrpy#689 to unblock 2.x support from vcrpy, your comment kevin1024/vcrpy#688 (comment) was a great hint. Started experimenting with that locally.

@hartwork hartwork merged commit 0291427 into hartwork:master May 8, 2023
@hartwork
Copy link
Owner

hartwork commented May 8, 2023

PS: @pquentin fixing vcr.py to work with both urllib3 1.x and 2.x turns out pretty hard and will eat quite a bit of time. I'm not sure I'll find the time needed to make it work.

@pquentin
Copy link
Contributor Author

pquentin commented May 9, 2023

Thanks for your own help fixing the ecosystem after we broke things! Would you have time to report why fixing vcrpy is hard and time consuming to help others build upon what you learned?

@hartwork
Copy link
Owner

hartwork commented May 9, 2023

@pquentin it's non-trivial in the sense that:

  • some imports to connectionpool need to be changed to connection and some cannot, i.e. the ones with the pool classes
  • so that situation requires a split of things and related changes
  • there is monkey patching to all sorts of bundled urllib3 copies happening, not just plain urllib3, it's many places
  • when mass patching all of that I now run into non-trivial errors now and that made me pause and reflect on how to continue economically.

Does that make sense?

@pquentin
Copy link
Contributor Author

pquentin commented May 9, 2023

This makes a lot of sense, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants