Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewritten the file to make it work with Redmine 4.2 #23

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mgi1982
Copy link

@mgi1982 mgi1982 commented Aug 14, 2021

This fixes the 500 you may get if you upgrade RM to 4.2.

@haru
Copy link
Owner

haru commented Aug 19, 2021

This PR fixes the conflicts with plugins which uses 'alias_method' funciton but makes new conflicts with plugins which uses 'prepend' function.
And you should use 'prepend' on Rails 5.
https://www.bigbinary.com/blog/rails-5-deprecates-alias-method-chain

@phlibi
Copy link

phlibi commented Sep 8, 2021

Are there any plans on integrating this patch or an improved one? We have recently added the checklists plugin of RedmineUP (https://www.redmineup.com/pages/plugins/checklists), which now causes the conflict when opening the project settings. I can confirm that the PR fixes the problem for at least this plugin combination. But using a more future-proof approach would certainly also be a good thing.

@haru
Copy link
Owner

haru commented Sep 9, 2021

Are there any plans on integrating this patch or an improved one?

No plans.
I think the checklists plugin should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants