Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Audio impl to relax trait bounds for spatial_buffered #57

Merged
merged 7 commits into from
Feb 14, 2023
Merged

Split Audio impl to relax trait bounds for spatial_buffered #57

merged 7 commits into from
Feb 14, 2023

Conversation

kcking
Copy link
Contributor

@kcking kcking commented Jan 20, 2023 •
edited
Loading

Objective

  • Fix spatial audio playback.

Solution

  • std::mem:forget(stream) instead of blocking bevy threads.
  • Add necessary initialization resources for spatial audio.

Changelog

  • Relaxed trait bounds for play_spatial_buffered to not require Seek.
  • Exposed static for configuring cpal settings.

harudagondi
harudagondi reviewed Feb 13, 2023
View reviewed changes
src/output.rs Outdated Show resolved Hide resolved
@harudagondi harudagondi merged commit 25ec115 into harudagondi:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harudagondi harudagondi harudagondi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kcking @harudagondi